[tor-dev] Add EVENT message to pt-spec.txt and control-spec.txt

Discussion:

David Goulet

2018-10-26 14:57:21 UTC

Greetings tor-dev!

We've been working on improving PT reporting towards Tor so for instance Tor
Browser can better inform the user or take actions based on the PT state when
connecting to the network.

The following ticket summarize it:
https://trac.torproject.org/projects/tor/ticket/28180

To achieve this, we are submitting these to torspec.git patches to extend both
the pt-spec.txt and control-spec.txt to support such mechanism. This is the
first draft.

Below is the link to the PT spec patch. It adds the EVENT message that for now
is only used, as you will see, for reporting connection status message.
However, you should see this EVENT message as extendable to whatever the PT
would like to report to Tor that we can think of in the future:

https://gitweb.torproject.org/user/dgoulet/torspec.git/commit/?h=ticket28181_01&id=0814114fb39f9f7ddf16de35f97092ed74ffd1ee

The second, is simpler, it is how Tor will send it back to the control port:

https://gitweb.torproject.org/user/dgoulet/torspec.git/commit/?h=ticket28182_01&id=b57d272f570847cdcf073b5fdf5b523d3f57d889

Please, any questions or feedbacks is very welcome! The main idea here is to
keep things simple and extendable.

Note that since Tor doesn't implement the PT 2.0 spec yet, we haven't done
anything for that spec but after skimming the version 2, I think we can easily
move this EVENT message concept if we want it.

Cheers!
David

--
t2Mtu4qBote14xSTFee/xnHlXp1eabwHFbehBlktnus=

Dr. Brandon Wiley

2018-10-26 18:31:27 UTC

Permalink

Well I think this is a great feature and it's something which people have
been requesting for a while now, and which I know was discussed at the PT
meeting at the last TorDev. I think this is the sort of feature that just
makes transports better for everyone, both transport designers and
applications that use transports. Several different options for this sort
of signalling have been discussed in the past at the Pluggable Transport
Implementers Meetings and it's nice to see a concrete proposal.

We have spent several years building a Pluggable Transport community which
includes a diverse group of tool developers that all use Pluggable
Transports. Tor is a key member of this group and has participated in all
of our meetings and the development of our community process for revision
of the Pluggable Transport specification. By following the community
process for proposing changes to the PT specification, all stakeholders get
a chance to provide feedback on the proposal and we an ensure ease of use
for developers in terms of clarity on backwards compatibility and semantic
versioning.

I would love to see this proposal submitted through the community
specification process for inclusion in the next release of the
specification. Simply add a proposal to the proposals/ directory of the
specification repository (
https://github.com/Pluggable-Transports/Pluggable-Transports-spec) and
issue a pull request. We will then add it to the schedule for review,
discussion, and eventual inclusion in a specification release.

Great work, and I look forward to working with you to get this useful
functionality for all transports and transport-enabled applications!

Post by David Goulet
Greetings tor-dev!
We've been working on improving PT reporting towards Tor so for instance Tor
Browser can better inform the user or take actions based on the PT state when
connecting to the network.
https://trac.torproject.org/projects/tor/ticket/28180
To achieve this, we are submitting these to torspec.git patches to extend both
the pt-spec.txt and control-spec.txt to support such mechanism. This is the
first draft.
Below is the link to the PT spec patch. It adds the EVENT message that for now
is only used, as you will see, for reporting connection status message.
However, you should see this EVENT message as extendable to whatever the PT
https://gitweb.torproject.org/user/dgoulet/torspec.git/commit/?h=ticket28181_01&id=0814114fb39f9f7ddf16de35f97092ed74ffd1ee
https://gitweb.torproject.org/user/dgoulet/torspec.git/commit/?h=ticket28182_01&id=b57d272f570847cdcf073b5fdf5b523d3f57d889
Please, any questions or feedbacks is very welcome! The main idea here is to
keep things simple and extendable.
Note that since Tor doesn't implement the PT 2.0 spec yet, we haven't done
anything for that spec but after skimming the version 2, I think we can easily
move this EVENT message concept if we want it.
Cheers!
David
--
t2Mtu4qBote14xSTFee/xnHlXp1eabwHFbehBlktnus=
_______________________________________________
tor-dev mailing list
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev

David Goulet

2018-10-29 15:35:22 UTC

Permalink

Post by Dr. Brandon Wiley
Well I think this is a great feature and it's something which people have
been requesting for a while now, and which I know was discussed at the PT
meeting at the last TorDev. I think this is the sort of feature that just
makes transports better for everyone, both transport designers and
applications that use transports. Several different options for this sort
of signalling have been discussed in the past at the Pluggable Transport
Implementers Meetings and it's nice to see a concrete proposal.
We have spent several years building a Pluggable Transport community which
includes a diverse group of tool developers that all use Pluggable
Transports. Tor is a key member of this group and has participated in all
of our meetings and the development of our community process for revision
of the Pluggable Transport specification. By following the community
process for proposing changes to the PT specification, all stakeholders get
a chance to provide feedback on the proposal and we an ensure ease of use
for developers in terms of clarity on backwards compatibility and semantic
versioning.
I would love to see this proposal submitted through the community
specification process for inclusion in the next release of the
specification. Simply add a proposal to the proposals/ directory of the
specification repository (
https://github.com/Pluggable-Transports/Pluggable-Transports-spec) and
issue a pull request. We will then add it to the schedule for review,
discussion, and eventual inclusion in a specification release.

https://github.com/Pluggable-Transports/Pluggable-Transports-spec/pull/3

Hope I did this correctly. You sure you don't want to switch to .txt file in
the proposal/. Seems PDF are hard to review on Github? ...

Cheers!
David

Post by Dr. Brandon Wiley
Great work, and I look forward to working with you to get this useful
functionality for all transports and transport-enabled applications!

_______________________________________________
tor-dev mailing list
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev

--
SHL0/USNzRrWTeGVvAVD4EyegSyFXMZ+kwG64G9rEbg=