[tor-dev] man: "IPv6 addresses should be wrapped in square brackets"

[nusenu]

Hi,

IPv6 addresses should be wrapped in square brackets

since it does not throw an error without square brackets:
does it make any difference?

Previously I forgot the square brackets when generating torrc
files with relayor and I would like to document the impact
of my bug (if there is any).

thanks,
nusenu

[grarpamp]

Post by nusenu

IPv6 addresses should be wrapped in square brackets

does it make any difference?
Previously I forgot the square brackets when generating torrc
files with relayor and I would like to document the impact
of my bug (if there is any).

I posting somewhere about normalizing IPv6 address format,
it might have listed the RFC, for which the man page and code was
probably inconsistant. Similar to how fingerprints are a mess.

[nusenu]

Post by grarpamp

Post by nusenu

IPv6 addresses should be wrapped in square brackets

does it make any difference?
Previously I forgot the square brackets when generating torrc
files with relayor and I would like to document the impact
of my bug (if there is any).

I posting somewhere about normalizing IPv6 address format,
it might have listed the RFC, for which the man page and code was
probably inconsistant. Similar to how fingerprints are a mess.

your text does not really answer my question..

[teor]

Post by nusenu
Hi,

IPv6 addresses should be wrapped in square brackets

does it make any difference?

When an option only takes an IP address, it does not make a difference.
(As long as the underlying code uses tor_addr_parse().)

When an option takes an IP address and port, the brackets are required to
separate the port from the IPv6 address. That's why we say that all IPv6
addresses should have square brackets.

Post by nusenu
Previously I forgot the square brackets when generating torrc
files with relayor and I would like to document the impact
of my bug (if there is any).

No impact, but you should use square brackets for consistency.

T

[David Fifield]

Post by teor
When an option only takes an IP address, it does not make a difference.
(As long as the underlying code uses tor_addr_parse().)

BTW there's currently a bug relating to this: if an address starts with
'[', tor_addr_parse strips the final byte whether or not it is ']'.
https://bugs.torproject.org/23082